Skip to content

fix(deps): update minimum dependency versions #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2024
Merged

fix(deps): update minimum dependency versions #2880

merged 1 commit into from
May 22, 2024

Conversation

JohnVillalovos
Copy link
Member

Update the minimum versions of the dependencies in the pyproject.toml file.

This is related to PR #2878

@JohnVillalovos JohnVillalovos requested a review from nejch May 22, 2024 03:31
nejch
nejch approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would just maybe change the commit type to at least fix as it's a user-facing change. Technically this could break for some people (e.g. if another dependency tracks requests with e.g. <=2.23.0 or something like that) and the dependencies will fail to resolve.

I can do this as part of the squash merge later, but I'll wait a bit in case you have feedback 👍

@nejch nejch changed the title chore: update minimum dependency versions in pyproject.toml fix: update minimum dependency versions in pyproject.toml May 22, 2024
@nejch nejch changed the title fix: update minimum dependency versions in pyproject.toml fix(deps): update minimum dependency versions May 22, 2024
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/use_pyproject branch from 7f38eaa to c6c1512 Compare May 22, 2024 14:02
@JohnVillalovos
Copy link
Member Author

LGTM, I would just maybe change the commit type to at least fix as it's a user-facing change. Technically this could break for some people (e.g. if another dependency tracks requests with e.g. <=2.23.0 or something like that) and the dependencies will fail to resolve.

I can do this as part of the squash merge later, but I'll wait a bit in case you have feedback 👍

Done. I updated the commit message.

Thanks.

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/use_pyproject branch from c6c1512 to 2df6346 Compare May 22, 2024 14:03
@JohnVillalovos
fix(deps): update minimum dependency versions in pyproject.toml
13ae5fd 
Update the minimum versions of the dependencies in the pyproject.toml
file.

This is related to PR #2878
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/use_pyproject branch from 2df6346 to 13ae5fd Compare May 22, 2024 14:35
@JohnVillalovos JohnVillalovos requested a review from nejch May 22, 2024 14:35
@JohnVillalovos JohnVillalovos merged commit 37b5a70 into main May 22, 2024
@JohnVillalovos JohnVillalovos deleted the jlvillal/use_pyproject branch May 22, 2024 15:36
@JohnVillalovos
Copy link
Member Author

@nejch Since you had approved it, I went ahead and merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch Awaiting requested review from nejch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnVillalovos @nejch