chore: update type-hints return signature for GetWithoutIdMixin methods #2036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit f0152dc removed situation where `get()` in a `GetWithoutIdMixin` based class could return `None` Update the type-hints to no longer return `Optional` AKA `None`
Codecov Report
@@ Coverage Diff @@
## main #2036 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 78 78
Lines 4941 4941
=======================================
Hits 4631 4631
Misses 310 310
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
reviewed
May 30, 2022
There was a problem hiding this comment.
Thanks @JohnVillalovos lgtm, just a quick question. There's another quirk with GetWithoutIdMixin I'll open a follow-up for.
nejch
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit f0152dc removed situation
where
get()in aGetWithoutIdMixinbased class could returnNoneUpdate the type-hints to no longer return
OptionalAKANone