Skip to content

chore: remove import of gitlab.utils from __init__.py #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2021
Merged

chore: remove import of gitlab.utils from __init__.py #1340

merged 1 commit into from
Feb 26, 2021

Conversation

JohnVillalovos
Copy link
Member

Initially when extracting out the gitlab/client.py code we tried to
remove this but functional tests failed.

Later we fixed the functional test that was failing, so now remove the
unneeded import.

Initially when extracting out the gitlab/client.py code we tried to
remove this but functional tests failed.

Later we fixed the functional test that was failing, so now remove the
unneeded import.
@codecov-io
Copy link

Codecov Report

Merging #1340 (39b9183) into master (cbd4f1e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   80.28%   80.28%   -0.01%     
==========================================
  Files          72       72              
  Lines        3744     3743       -1     
==========================================
- Hits         3006     3005       -1     
  Misses        738      738              
Flag Coverage Δ
unit 80.28% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/__init__.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd4f1e...39b9183. Read the comment docs.

@max-wittig max-wittig merged commit d0eb1b5 into python-gitlab:master Feb 26, 2021
@JohnVillalovos JohnVillalovos deleted the jlvillal/gitlab_init branch February 27, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants