Skip to content

Upgrade to ShipService_v26 and RateService_v28 #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2023
Merged

Upgrade to ShipService_v26 and RateService_v28 #157

merged 2 commits into from
Mar 22, 2023

Conversation

Linekio
Copy link
Contributor

@Linekio Linekio commented Sep 30, 2021

Fix #154

@IrinaAlexandra
Copy link

Hey, what is needed to get this merged in? Can I help?

@radzhome
Copy link
Member

radzhome commented Apr 8, 2022

Hey did anyone see if the tests are all passing? Any updates to tests?

radzhome
radzhome reviewed Apr 8, 2022
View reviewed changes
Copy link
Member

@radzhome radzhome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would need to run tests, make sure nothing broke.. any new features needs to be added to tests?

@Linekio
Copy link
Contributor Author

Linekio commented Apr 9, 2022

Hi,

  • I just rebased the branch
  • I ran tests :
$ python -m unittest
ss.sssssssss.s
----------------------------------------------------------------------
Ran 14 tests in 0.217s

OK (skipped=12)

@isdabenx
Copy link

How can I help so that this is in the master branch?

@IrinaAlexandra
Copy link

any updates on this?

@isdabenx
Copy link

@radzhome How can I help so that this is in the master branch?

@radzhome radzhome merged commit 8690829 into python-fedex-devs:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radzhome radzhome radzhome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating Ship Service to version 26 including WSDL File ShipService_v26
4 participants
@Linekio @IrinaAlexandra @radzhome @isdabenx