Fixes to the build and test of Slycot, (part of the work in #25) #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* conda recipes, meta.yaml, and batch files
- in meta.yaml, ensure test is under same python version as build
- keep the openblas conda recipe in separate folder
- re-worked windows build to use Flang fortran and vc14 linkage
- use conda's compiler('fortran') for linux and mac osx
* travis configuration
- force installation of slycot from the local channel, avoid using a
conda-forge version in the case of previous build failure
- use lapack libs for conda and non-conda builds
- add conda-forge channel to the conda config, to find lapack
* slycot/setup.py
- fix for compile on Darwin/Linux,
- add library path based on python location, for conda builds
- adjust linker options for Linux (specifically ubuntu)
- read the environment variable LAPACKLIBS to override the
used Lapack libraries
|
Looks good, just fails on the quadratic again. Thanks for suggesting splitting the PR's. It was a bit of work, but I learned in the process. |
|
Thanks for taking the time to split these out. Great to have a working CI process again (or almost, at least -:). I want to run the changes on my local machine just to make sure some of the earlier problems go away and then I'll merge these into master. For posterity, this PR addresses issue #23 and there is a discussion in PR #24 and (especially) PR #25. |
This was referenced Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conda recipes, meta.yaml, and batch files
travis configuration
conda-forge version in the case of previous build failure
slycot/setup.py
used Lapack libraries