Skip to content

Translate library/pyclbr.po #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 12, 2025
Merged

Translate library/pyclbr.po #1095

merged 11 commits into from
Jul 12, 2025

Conversation

LamentXU123
Copy link
Contributor

@LamentXU123 LamentXU123 commented Jul 9, 2025 •
edited
Loading

nested functions: 巢狀函式
top-level functioins: 頂層函式
superclass：超类

第一次出現時均著明原文。

@LamentXU123 LamentXU123 mentioned this pull request Jul 9, 2025
Closed
@mattwang44
Copy link
Collaborator

@Dr-XYZ would you please help reviewing this PR?

@Dr-XYZ
Copy link
Collaborator

Dr-XYZ commented Jul 9, 2025

@Dr-XYZ would you please help reviewing this PR?

Sure

Dr-XYZ
Dr-XYZ reviewed Jul 9, 2025
View reviewed changes
@LamentXU123
Copy link
Contributor Author

LamentXU123 commented Jul 9, 2025 •
edited
Loading

Good review, Thanks! @mattwang44 would you mind to review again? TiA🙏

@LamentXU123 @Dr-XYZ
Apply suggestions from code review
d744314 
Co-authored-by: Dr.XYZ <dr.xyz.tw@gmail.com>
@Dr-XYZ
Copy link
Collaborator

Dr-XYZ commented Jul 9, 2025

@LamentXU123 很多術語錯誤我只標出第一次出現，剩下的你用poedit的replace替換比較快。

@LamentXU123
Copy link
Contributor Author

LamentXU123 commented Jul 9, 2025 •
edited
Loading

@LamentXU123 很多術語錯誤我只標出第一次出現，剩下的你用poedit的replace替換比較快。

Done, Thanks!

我再檢查一下

@LamentXU123
Copy link
Contributor Author

我看了一下大概没什么问题了。@mattwang44 请你再来review一下，Thanks！！❤

1 similar comment
@LamentXU123
Copy link
Contributor Author

我看了一下大概没什么问题了。@mattwang44 请你再来review一下，Thanks！！❤

Dr-XYZ
Dr-XYZ reviewed Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@Dr-XYZ Dr-XYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這兩個地方以及句號後面的空格沒改到

@LamentXU123
Copy link
Contributor Author

LamentXU123 commented Jul 10, 2025 •
edited
Loading

這兩個地方以及句號後面的空格沒改到

其实英文原文里也有很多redundant的空格......他们好像不在意这些（python/cpython#136200 ）

但是改了总比不改好。Thanks！

@Dr-XYZ
Copy link
Collaborator

Dr-XYZ commented Jul 10, 2025

其实英文原文里也有很多redundant的空格......他们好像不在意这些（python/cpython#136200 ）

英文原文是那邊本來就要有空格，但中文句號後面不應該有空格

@LamentXU123
Copy link
Contributor Author

其实英文原文里也有很多redundant的空格......他们好像不在意这些（python/cpython#136200 ）

英文原文是那邊本來就要有空格，但中文句號後面不應該有空格

不他們的文檔裏有很多詞語之間有兩個空格的情況 XD

@LamentXU123 @Dr-XYZ
Apply suggestions from code review
7089f93 
Co-authored-by: Dr.XYZ <dr.xyz.tw@gmail.com>
@Dr-XYZ
Copy link
Collaborator

Dr-XYZ commented Jul 10, 2025

不他們的文檔裏有很多詞語之間有兩個空格的情況 XD

英文原文詞語之間兩個空格在 Docs 顯示時會自動忽略多於空格，但句號後面還是會有一個空格，不符合翻譯守則

@LamentXU123
Copy link
Contributor Author

英文原文詞語之間兩個空格在 Docs 顯示時會自動忽略多於空格，但句號後面還是會有一個空格，不符合翻譯守則

Got it! Thank you very much for teaching this

mattwang44
mattwang44 reviewed Jul 10, 2025
View reviewed changes
LamentXU123 and others added 2 commits July 11, 2025 10:36
@LamentXU123 @mattwang44
Apply suggestions from code review
cff52f6 
Co-authored-by: W. H. Wang <mattwang44@gmail.com>
@LamentXU123
Update pyclbr.po
6e4d022
@LamentXU123
Copy link
Contributor Author

Thanks！我把標點後面的空格去掉了。

@LamentXU123 LamentXU123 requested a review from mattwang44 July 11, 2025 02:41
@mattwang44 mattwang44 requested a review from Dr-XYZ July 11, 2025 03:53
mattwang44
mattwang44 reviewed Jul 11, 2025
View reviewed changes
@LamentXU123 LamentXU123 requested a review from mattwang44 July 11, 2025 05:40
mattwang44
mattwang44 previously approved these changes Jul 11, 2025
View reviewed changes
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Dr-XYZ 可以請你也做最後 review 嗎

Dr-XYZ
Dr-XYZ reviewed Jul 11, 2025
View reviewed changes
@LamentXU123 @Dr-XYZ
Update library/pyclbr.po
03fb817 
Co-authored-by: Dr.XYZ <dr.xyz.tw@gmail.com>
@mattwang44 mattwang44 merged commit b208964 into python:3.13 Jul 12, 2025
1 check passed
@mattwang44
Copy link
Collaborator

Thank you folks!

@mattwang44 mattwang44 linked an issue Jul 12, 2025 that may be closed by this pull request
Translate library/pyclbr.po #1094
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-XYZ Dr-XYZ Dr-XYZ approved these changes

@mattwang44 mattwang44 mattwang44 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate library/pyclbr.po
3 participants
@LamentXU123 @mattwang44 @Dr-XYZ