-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
[3.13] gh-136759: rename lock.h
to pylock.h
(GH-137041)
#137075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 14bf176 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137075%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Oh no no no, this is way too big a change for 3.13. The file system layout is fixed from beta 1 - changing in 3.14rc2 is a big enough breach of our compatibility policy, but this one should definitely be reverted (as annoying as that is for people with other projects that provide this file). Our own references to the header should be relative (i.e. |
GH-137166 is a backport of this pull request to the 3.13 branch. |
…GH-137041) (python#137075)" This reverts commit 74503ac.
Sorry, I created the revert PR here #137166 but it does mean that this issue will be forever in 3.13. |
Yeah, that's the nature of compatibility! It also means that anyone whose |
Rename
lock.h
topylock.h
to avoid conflicts with headers of other projects. (cherry picked from commit ec02db5)