Skip to content

[3.14] gh-124621: Emscripten: Support pyrepl in browser (GH-136931) #136988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Jul 22, 2025

Basic support for pyrepl in Emscripten. Limitations:

  • requires JSPI
  • no signal handling implemented

As followup work, it would be nice to implement a webworker variant for when JSPI is not available and proper signal handling.

Because it requires JSPI, it doesn't work in Safari. Firefox requires setting an experimental flag. All the Chromiums have full support since May. Until we make it work without JSPI, let's keep the original web_example around.
(cherry picked from commit c933a6b)

…GH-136931)

Basic support for pyrepl in Emscripten. Limitations:
* requires JSPI
* no signal handling implemented

As followup work, it would be nice to implement a webworker variant
for when JSPI is not available and proper signal handling.

Because it requires JSPI, it doesn't work in Safari. Firefox requires
setting an experimental flag. All the Chromiums have full support since
May. Until we make it work without JSPI, let's keep the original web_example
around.
(cherry picked from commit c933a6b)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Éric <merwok@netwok.org>
@ambv
Copy link
Contributor Author

ambv commented Jul 22, 2025

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit 0b06534 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136988%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

hoodmane added a commit to hoodmane/cpython that referenced this pull request Jul 22, 2025
If there is an error, we have to return `-errno` not positive errno.
Included in backport of pythonGH-136931: python#136988
@hoodmane
Copy link
Contributor

hoodmane commented Jul 22, 2025

Opened #136993 with the change I committed in 9dad34c.

@hoodmane
Copy link
Contributor

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 3250ce4 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136988%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

@ambv ambv merged commit 591019e into python:3.14 Jul 22, 2025
52 checks passed
@ambv ambv deleted the backport-c933a6b-3.14 branch July 22, 2025 13:05
ambv pushed a commit that referenced this pull request Jul 22, 2025
If there is an error, we have to return `-errno` not positive errno.
Included in backport of GH-136931: #136988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-repl Related to the interactive shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants