Skip to content

gh-133742: Fix test_sysconfig and test_build_details for relocated directories #136987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

gh-133742: Fix test_sysconfig and test_build_details for relocated directories #136987

merged 1 commit into from
Jul 22, 2025

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 22, 2025 •
edited by bedevere-app bot
Loading

@pablogsal pablogsal requested a review from FFY00 as a code owner July 22, 2025 11:27
@pablogsal pablogsal added needs backport to 3.14 bugs and security fixes skip news labels Jul 22, 2025
@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Jul 22, 2025
@pablogsal
Copy link
Member Author

Before:

   'py_version_short': '3.15',
-  'srcdir': '/home/pablogsal/github/python/main/ins2/lib/python3.15/config-3.15d-x86_64-linux-gnu'}
?                                                   -

+  'srcdir': '/home/pablogsal/github/python/main/ins/lib/python3.15/config-3.15d-x86_64-linux-gnu'}

0:00:00 load avg: 2.40 [1/2/1] test_sysconfig failed (1 failure)
0:00:00 load avg: 2.40 [2/2/1] test_build_details
======================================================================
FAIL: test_base_interpreter (test.test_build_details.CPythonBuildDetailsTests.test_base_interpreter)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/pablogsal/github/python/main/ins2/lib/python3.15/test/test_build_details.py", line 127, in test_base_interpreter
    self.assertEqual(os.path.realpath(value), os.path.realpath(sys.executable))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '/home/pablogsal/github/python/main/ins/bin/python3.15' != '/home/pablogsal/github/python/main/ins2/bin/python3.15'
- /home/pablogsal/github/python/main/ins/bin/python3.15
+ /home/pablogsal/github/python/main/ins2/bin/python3.15
?                                       +


======================================================================
FAIL: test_c_api (test.test_build_details.CPythonBuildDetailsTests.test_c_api)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/pablogsal/github/python/main/ins2/lib/python3.15/test/test_build_details.py", line 137, in test_c_api
    self.assertTrue(os.path.exists(os.path.join(value['headers'], 'Python.h')))
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true0:00:00 load avg: 2.40 [2/2/2] test_build_details failed (2 failures)

== Tests result: FAILURE ==

2 tests failed:
    test_build_details test_sysconfig

Total duration: 531 ms
Total tests: run=47 failures=3 skipped=3
Total test files: run=2/2 failed=2
Result: FAILURE

After:

./ins2/bin/python3 -m test test_sysconfig test_build_details
Using random seed: 403838756
0:00:00 load avg: 2.60 Run 2 tests sequentially in a single process
0:00:00 load avg: 2.60 [1/2] test_sysconfig
0:00:00 load avg: 2.60 [1/2] test_sysconfig passed
0:00:00 load avg: 2.60 [2/2] test_build_details
0:00:00 load avg: 2.60 [2/2] test_build_details passed

== Tests result: SUCCESS ==

All 2 tests OK.

Total duration: 451 ms
Total tests: run=47 skipped=5
Total test files: run=2/2
Result: SUCCESS

@pablogsal pablogsal enabled auto-merge (squash) July 22, 2025 11:42
@pablogsal pablogsal merged commit aafbdb5 into python:main Jul 22, 2025
51 of 52 checks passed
@pablogsal pablogsal deleted the gh-133742 branch July 22, 2025 11:53
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2025
@pablogsal @miss-islington
pythongh-133742: Fix test_sysconfig and test_build_details for reloca…
3622f52 
…ted directories (pythonGH-136987)

(cherry picked from commit aafbdb5)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 22, 2025

GH-136990 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 22, 2025
@pablogsal pablogsal mentioned this pull request Jul 22, 2025
Closed
pablogsal added a commit that referenced this pull request Jul 22, 2025
@miss-islington @pablogsal
[3.14] gh-133742: Fix test_sysconfig and test_build_details for reloc…
8e3c3b5 
…ated directories (GH-136987) (#136990)

gh-133742: Fix test_sysconfig and test_build_details for relocated directories (GH-136987)
(cherry picked from commit aafbdb5)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pablogsal