gh-136437: Convert more os.path functions to pos-only in the docs
#136970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
awaiting core review
docs
sobolevn
added
needs backport to 3.13
AA-Turner
approved these changes
Jul 22, 2025
|
Thanks @sobolevn for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 22, 2025
…y in the docs (pythonGH-136970) (cherry picked from commit b31e5d6) Co-authored-by: sobolevn <mail@sobolevn.me>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 22, 2025
…y in the docs (pythonGH-136970) (cherry picked from commit b31e5d6) Co-authored-by: sobolevn <mail@sobolevn.me>
|
GH-137000 is a backport of this pull request to the 3.14 branch. |
|
GH-137001 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for reviewing:
os.path.joinhas(a, *p)real signature vs(path, *paths)documented inposixpathrealpathhas(filename, *, strict=False)real vs(path, *, strict=False)documentedcommonprefix:(m)real vs(list)documentedgetsizeandget[a,m,c]timethat have(filename)real vs(path)documentedsamestathas(s1, s2)real vs(stat1, stat2)documentedsamefilehas(f1, f2)real vs(path1, path2)documentedAny others that I've missed?
os.pathdocumentation vs. runtime #136437📚 Documentation preview 📚: https://cpython-previews--136970.org.readthedocs.build/