GH-111758: Merge TSan and UBSan reusable GHA workflows #136820
Merged
+139
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
commented
Jul 19, 2025
webknjaz
commented
Jul 19, 2025
webknjaz
commented
Jul 19, 2025
.github/workflows/reusable-ubsan.yml
Outdated
There was a problem hiding this comment.
Note
Prior to this PR, this workflow wasn't contributing to the branch protection status. Once it's merged, it'll fail the PRs if something crashes.
webknjaz
commented
Jul 19, 2025
webknjaz
commented
Jul 19, 2025
.github/workflows/reusable-san.yml
Outdated
| build-tsan-reusable: | ||
| name: 'Thread sanitizer' | ||
| build-san-reusable: | ||
| name: ${{ inputs.sanitizer }} |
There was a problem hiding this comment.
Per discussion w/ Hugo, this needs to mention the FT flag.
webknjaz
commented
Jul 19, 2025
webknjaz
force-pushed
the
maintenance/111758-gha-combined-san
branch
2 times, most recently
from
8592567 to
115b8e3
Compare
Co-Authored-By: Sviatoslav Sydorenko <webknjaz@redhat.com>
webknjaz
force-pushed
the
maintenance/111758-gha-combined-san
branch
from
115b8e3 to
219e287
Compare
webknjaz
requested review from
ezio-melotti,
hugovk and
AA-Turner
as code owners
hugovk
reviewed
Jul 20, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
@hugovk I think this needs backport labels to keep the CI in other branches close. |
hugovk
added
needs backport to 3.13
hugovk
approved these changes
Jul 20, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 20, 2025
…H-136820) (cherry picked from commit 65d2c51c10425dcfacc0a13810d58c41240d7ff9) Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
Sorry, @webknjaz and @hugovk, I could not cleanly backport this to |
|
GH-136883 is a backport of this pull request to the 3.14 branch. |
hugovk
added a commit
that referenced
this pull request
Jul 20, 2025
) (#136883) Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
I'd suggest reverting partially if needed, but the job grouping and generalization are good to keep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch deduplicates the contents of
reusable-tsan.ymlandreusable-ubsan.yml, making them one. The new workflow replaces the duplicated ones in the top-levelbuild.ymland are called with different sanitizer parameters.It is based on Hugo's patch. Context: