gh-136744: Remove unnecessary chmod from pydoc.apropos() test. #136746
+3
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test added as part of fixing #65747 includes a chmod call that appears to be unrelated to the problem that was reported.
Part of the triage of that issue included the observation that the problem could be reproduced by removing execute permissions from a directory. However, this appears to be unrelated to the reported problem.
By removing the execute permission from the directory, the module is converted into a namespace package - at which point, it can't have a docstring. However, you can also validate empty docstring handling by... having a module without a docstring. Which is what the test implements.
Adding to the confusion - the test only removes user execute permissions. Group and Global execute permissions are retained. The original report removed all execute permissions, not just user execute permissions; so the test isn't reproducing the triage example. The only explanation I can think of for this is that the buildbots run with a umask of 0o77, which means removing user execute permissions is effectively equivalent to
chmod a-x
... but it won't be for anyone who isn't running under buildbot.This PR removes the chmod call, which also allows for removing the workaround for Emscripten.
Thanks to @hoodmane for help diagnosing what was going on here.