Skip to content

gh-136063: fix quadratic-complexity parsing in email.message._parseparam #136072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-136063: fix quadratic-complexity parsing in email.message._parseparam #136072

wants to merge 3 commits into from
+46 −10

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jun 28, 2025 •
edited by bedevere-app bot
Loading

@serhiy-storchaka I think this one can be done without changing the interface. Just to be sure, but count() and find() have all linear complexities right (linear in the window they are using, not in the entire string).

@bedevere-app bedevere-app bot mentioned this pull request Jun 28, 2025
Open
@picnixz picnixz force-pushed the fix/email/parseparam-dos-136063 branch from 8763366 to d356a14 Compare June 28, 2025 12:44
@picnixz picnixz requested a review from serhiy-storchaka June 28, 2025 12:49
@picnixz picnixz marked this pull request as ready for review June 28, 2025 12:49
@picnixz picnixz requested a review from a team as a code owner June 28, 2025 12:49
@picnixz picnixz added the type-security A security issue label Jun 29, 2025
aeurielesn
aeurielesn reviewed Jul 19, 2025
View reviewed changes
@picnixz picnixz marked this pull request as draft July 20, 2025 07:54
@picnixz picnixz marked this pull request as ready for review July 20, 2025 09:09
@picnixz picnixz added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeurielesn aeurielesn aeurielesn left review comments

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees
No one assigned
Labels
awaiting core review needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picnixz @aeurielesn