Skip to content

GH-132661: Add string.templatelib.convert() #135217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 15, 2025
Merged

GH-132661: Add string.templatelib.convert() #135217

merged 4 commits into from
Jul 15, 2025

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Jun 6, 2025 •
edited
Loading

See https://discuss.python.org/t/94569/. cc @davepeck @treyhunner.

Sketch implementation. Skip news as this would be part of the larger PEP 750 piece.

A

📚 Documentation preview 📚: https://cpython-previews--135217.org.readthedocs.build/

@AA-Turner AA-Turner requested a review from lysnikolaou as a code owner June 6, 2025 14:53
@bedevere-app bedevere-app bot mentioned this pull request Jun 6, 2025
Open
@lysnikolaou
Copy link
Member

There's some test failures here. @hugovk Would it be okay if we backported this to 3.14?

lysnikolaou
lysnikolaou reviewed Jul 10, 2025
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just add string.templatelib.convert in this PR and leave docs for the big docs PR that currently in review.

@hugovk
Copy link
Member

hugovk commented Jul 11, 2025

@hugovk Would it be okay if we backported this to 3.14?

Yes, this makes sense to be part of the PEP 750 stuff. RC1 is soon: 2025-07-22.

@lysnikolaou
Copy link
Member

@AA-Turner Are you going to work on this to simplify it down to just adding convert?

@AA-Turner
Copy link
Member Author

Yes, sorry (at EuroPython). Hopefully will have time this afternoon.

A

@AA-Turner AA-Turner requested a review from lysnikolaou July 15, 2025 07:52
@AA-Turner AA-Turner added the needs backport to 3.14 bugs and security fixes label Jul 15, 2025
lysnikolaou
lysnikolaou approved these changes Jul 15, 2025
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @AA-Turner!

@lysnikolaou lysnikolaou merged commit 5b969fd into python:main Jul 15, 2025
46 checks passed
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR, and @lysnikolaou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2025
@AA-Turner @miss-islington
pythonGH-132661: Add string.templatelib.convert() (pythonGH-135217)
d0e51ee 
(cherry picked from commit 5b969fd)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 15, 2025

GH-136671 is a backport of this pull request to the 3.14 branch.

@AA-Turner AA-Turner deleted the templatelib-convert branch July 15, 2025 09:57
@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 15, 2025
@AA-Turner AA-Turner mentioned this pull request Jul 15, 2025
Merged
AA-Turner added a commit that referenced this pull request Jul 15, 2025
@miss-islington @AA-Turner
[3.14] GH-132661: Add string.templatelib.convert() (GH-135217) (#…
2ae0eb1 
…136671)

GH-132661: Add ``string.templatelib.convert()`` (GH-135217)
(cherry picked from commit 5b969fd)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@davepeck
Copy link
Contributor

davepeck commented Jul 15, 2025 •
edited
Loading

🎉 Thanks, @AA-Turner ! I'll add docs for this to #135229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AA-Turner @lysnikolaou @hugovk @davepeck