Skip to content

Further improvement on packages and demos #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 2, 2021

Conversation

jr2804
Copy link

@jr2804 jr2804 commented Mar 1, 2021

  • added 64-bit support for all packages
  • renamed all VCL files to WrapDelphiVcl*.pas
  • put them in subfolder vcl & updated project
  • Updated demos according to new structure

* renamed all VCL files to WrapDelphiVcl*.pas
* put them in subfolder vcl & updated project
* Updated demos according to new structure
@pyscripter
Copy link
Owner

pyscripter commented Mar 1, 2021

Good stuff! Thanks!

May I ask for a couple of changes:

  • // {$include ../Definitions.inc} If the line is not needed just deleted
  • I prefer WrapVclDialogs instead of WrapDelphiVclDialogs etc. This matches WrapFmxDialogs etc.

Also by "added 64-bit support for all packages" you mean run-time packages, right?

@jr2804
Copy link
Author

jr2804 commented Mar 2, 2021

Suggested changes were implemented.

"added 64-bit support for all packages" simply means that 64-bit platform was added in the projects:
image
(only 32-bit was included so far?)

@pyscripter pyscripter merged commit 07b7b4d into pyscripter:master Mar 2, 2021
@pyscripter
Copy link
Owner

Thanks!!

@jr2804 jr2804 deleted the improvements_vcl_projectfiles branch May 7, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants