Skip to content

feat: Support add convert_classic_histograms_to_nhcb option for prometheus global config #7543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dongjiang1989
Copy link
Member

@dongjiang1989 dongjiang1989 commented May 20, 2025

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

ref: prometheus/prometheus#16226

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

add `convert_classic_histograms_to_nhcb` option for prometheus global config

…onfig

Signed-off-by: dongjiang <dongjiang1989@126.com>
@dongjiang1989 dongjiang1989 marked this pull request as ready for review May 20, 2025 03:39
@dongjiang1989 dongjiang1989 requested a review from a team as a code owner May 20, 2025 03:39
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simonpasquier simonpasquier merged commit 6e6db29 into prometheus-operator:main May 20, 2025
23 checks passed
@dongjiang1989 dongjiang1989 deleted the add-ConvertClassicHistogramsToNHCB branch May 20, 2025 11:47
@simonpasquier simonpasquier mentioned this pull request May 28, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants