Skip to content

[release-2.53 LTS] Backward compatibility with upcoming index v3 #16762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

bwplotka
Copy link
Member

This is similar to #14939 but expanded to our current LTS release 2.53

We decided (chat, issue) to ensure that for TSDB breaking changes, we want to guarantee reversibility to the last LTS to ensure smooth migration experience.

For the v3 only want to support reading v3 index file that will not contain any changes other than removal of some unused fields from the index (#14749)

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
@bwplotka
Copy link
Member Author

Tested with a quick test script: https://gist.github.com/bwplotka/cb4eb538850cd9bf35de52c708037a6d

@bboreham
Copy link
Member

I think there should be an issue filed which says what goes wrong if we don't merge this.

It is hinted at in #14749 ("Is downgrading from v3.x to a pre-v2.55.0 version completely unsupported").

Since you tried it, @bwplotka, can you file the issue?

@bboreham
Copy link
Member

This is similar to #14939 but expanded to our current LTS release 2.53

The diffs seem identical to me; what is "expanded" ?

@bboreham
Copy link
Member

bboreham commented Jun 23, 2025

I think there should be an issue filed which says what goes wrong if we don't merge this.

A quick 2-minute test says it works fine. Going to guess that we need a slow test, i.e. with some blocks created after a few hours.

Update: I added --storage.tsdb.min-block-duration=65s to make block creation happen faster (idea from #16550), and it still starts up without error after downgrading from v3.0.1 to v2.53.4.

@bwplotka
Copy link
Member Author

What will fail: If we actually execute on #14749 (change index version) you will see failures on this LTS and generally before 2.55 (we ported all above)

@bwplotka
Copy link
Member Author

Built quay.io/bwplotka/prometheus:v3-index that simulates Prometheus with this issue completed.

@bboreham
Copy link
Member

Ah, thanks. That wasn't clear to me.

Can you please answer the question on #14749 ("Is downgrading from v3.x to a pre-v2.55.0 version completely unsupported").
(I think the answer is it is supported for all x from 0 to 5 at least).

@bwplotka
Copy link
Member Author

Good question, i answered on the #14749 (comment)

@bwplotka
Copy link
Member Author

bwplotka commented Jun 24, 2025

...so, are we ok to merge this @bboreham ? (:

@bwplotka bwplotka merged commit eb44f92 into release-2.53 Jun 25, 2025
47 checks passed
@bwplotka bwplotka deleted the v3index-2.53-lts branch June 25, 2025 08:11
machine424 added a commit to machine424/prometheus that referenced this pull request Jun 30, 2025
given a v3 compatible LTS 2.53 is now available after prometheus#16762

Signed-off-by: machine424 <ayoubmrini424@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants