-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[release-2.53 LTS] Backward compatibility with upcoming index v3 #16762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Tested with a quick test script: https://gist.github.com/bwplotka/cb4eb538850cd9bf35de52c708037a6d |
The diffs seem identical to me; what is "expanded" ? |
A quick 2-minute test says it works fine. Going to guess that we need a slow test, i.e. with some blocks created after a few hours. Update: I added |
What will fail: If we actually execute on #14749 (change index version) you will see failures on this LTS and generally before 2.55 (we ported all above) |
Built quay.io/bwplotka/prometheus:v3-index that simulates Prometheus with this issue completed. |
Ah, thanks. That wasn't clear to me. Can you please answer the question on #14749 ("Is downgrading from v3.x to a pre-v2.55.0 version completely unsupported"). |
Good question, i answered on the #14749 (comment) |
...so, are we ok to merge this @bboreham ? (: |
given a v3 compatible LTS 2.53 is now available after prometheus#16762 Signed-off-by: machine424 <ayoubmrini424@gmail.com>
This is similar to #14939 but expanded to our current LTS release 2.53
We decided (chat, issue) to ensure that for TSDB breaking changes, we want to guarantee reversibility to the last LTS to ensure smooth migration experience.
For the v3 only want to support reading v3 index file that will not contain any changes other than removal of some unused fields from the index (#14749)