Add parse alerting for rules files before loading WAL #16601
Merged
+59
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subhramit
force-pushed
the
parse-alerting-wal
branch
7 times, most recently
from
4ef8f8a to
30f913e
Compare
Builds over prometheus#16462 Addresses comments, adds invalid rules file Co-authored-by: marcodebba <marcodebonis74@gmail.com> Co-authored-by: subhramit <subhramit.bb@live.in> Signed-off-by: subhramit <subhramit.bb@live.in>
subhramit
force-pushed
the
parse-alerting-wal
branch
from
30f913e to
fbf01ef
Compare
subhramit
changed the title
tjhop
approved these changes
May 21, 2025
|
Hi team, would anything else be needed here? Or could this be merged? |
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to pre-parse rules files before the WAL is loaded, ensuring that invalid rule files are caught early. Key changes include:
- Adding a new function (ParseFiles) to parse rule files from glob patterns.
- Introducing tests in manager_test.go to validate both successful and failing parsing scenarios.
- Updating the main application logic (in cmd/prometheus/main.go) to invoke the new parsing step.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rules/manager_test.go | Added tests for validating both valid and invalid rules files. |
| rules/manager.go | Introduced the ParseFiles function to pre-parse rule files. |
| rules/fixtures/invalid_rules.yaml | Added a fixture for an invalid rule file to test error handling. |
| cmd/prometheus/main.go | Updated main to call ParseFiles to verify rule files before loading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11486
Add functionality (and corresponding test) to parse rules files before loading the WAL.
rules/fixturesto test the error case of the parse function.This eliminates infinite systemd crash-restart loops due to invalid rules files that caused disk exhaustion and multi-day outages as mentioned in the issue.
Refs. #7322, #7399