Skip to content

test: unbreak test config in 3 __utils__ #9644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChALkeR
Copy link
Contributor

@ChALkeR ChALkeR commented Jun 14, 2025

__utils__ dir has multiple issues

  1. These tests are not run from CI (top-level script runs _test, these are called test)
  2. __utils__/assert-store/test/index.ts and __utils__/assert-project/test/index.ts were not found by default jest pattern, and there was no jest config in these dirs, so even pnpm test in those dirs found no tests
  3. assert-store, assert-project, test-ipc-server tests failed because ts-jest was not configured and tests are typescript
  4. Even with above issues fixed, assert-store tests are broken
    (as the util itself, see test: storeHas/storeHasNot assertions are broken [Do not merge] #9645)

This PR addresses (2) and (3) by fixing jest config in these dirs

(1) could be fixed with e.g. a setup similar to this (like other packages do):

    "_test": "pnpm pretest && jest",
    "test": "pnpm run compile && pnpm run _test",

But it needs first addressing (4), which should be done separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant