ext/xml: Suppress libxml deprecation for _xmlParserCtxt.inState
#19131
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FreeBSD build fails due to the deprecation and -Werror:
2025-07-15T00:37:20.8390774Z /home/runner/work/php-src/php-src/ext/xml/compat.c:358:38: error: 'instate' is deprecated [-Werror,-Wdeprecated-declarations]
2025-07-15T00:37:20.8392577Z 358 | if (ret == NULL || parser->parser->instate == XML_PARSER_CONTENT) {
2025-07-15T00:37:20.8393184Z | ^
2025-07-15T00:37:20.8394006Z /usr/local/include/libxml2/libxml/parser.h:309:33: note: 'instate' has been explicitly marked deprecated here
2025-07-15T00:37:20.8394903Z 309 | xmlParserInputState instate XML_DEPRECATED_MEMBER;
2025-07-15T00:37:20.8395413Z | ^
2025-07-15T00:37:20.8396166Z /usr/local/include/libxml2/libxml/xmlexports.h:74:50: note: expanded from macro 'XML_DEPRECATED_MEMBER'
2025-07-15T00:37:20.8397058Z 74 | #define XML_DEPRECATED_MEMBER __attribute__((deprecated))
2025-07-15T00:37:20.8397581Z | ^
2025-07-15T00:37:20.8425542Z 1 error generated.
|
Merging this now for the 8.5.0alpha2 release to be green. |
|
Can we backport this? Nightly for 8.4 also fails. https://github.com/php/php-src/actions/runs/16308227434/job/46058664411 |
|
I'll leave backporting / further handling up to Niels. The main goal was unblocking the CI for the Alpha 2 tag in the simplest possible way. |
|
I'll backport it to 8.1+ for the time being |
nielsdos
pushed a commit
that referenced
this pull request
Jul 16, 2025
…9131) The FreeBSD build fails due to the deprecation and -Werror: 2025-07-15T00:37:20.8390774Z /home/runner/work/php-src/php-src/ext/xml/compat.c:358:38: error: 'instate' is deprecated [-Werror,-Wdeprecated-declarations] 2025-07-15T00:37:20.8392577Z 358 | if (ret == NULL || parser->parser->instate == XML_PARSER_CONTENT) { 2025-07-15T00:37:20.8393184Z | ^ 2025-07-15T00:37:20.8394006Z /usr/local/include/libxml2/libxml/parser.h:309:33: note: 'instate' has been explicitly marked deprecated here 2025-07-15T00:37:20.8394903Z 309 | xmlParserInputState instate XML_DEPRECATED_MEMBER; 2025-07-15T00:37:20.8395413Z | ^ 2025-07-15T00:37:20.8396166Z /usr/local/include/libxml2/libxml/xmlexports.h:74:50: note: expanded from macro 'XML_DEPRECATED_MEMBER' 2025-07-15T00:37:20.8397058Z 74 | #define XML_DEPRECATED_MEMBER __attribute__((deprecated)) 2025-07-15T00:37:20.8397581Z | ^ 2025-07-15T00:37:20.8425542Z 1 error generated.
nielsdos
added a commit
that referenced
this pull request
Jul 16, 2025
* PHP-8.1: ext/xml: Suppress libxml deprecation for `_xmlParserCtxt.inState` (#19131)
nielsdos
added a commit
that referenced
this pull request
Jul 16, 2025
* PHP-8.2: ext/xml: Suppress libxml deprecation for `_xmlParserCtxt.inState` (#19131)
nielsdos
added a commit
that referenced
this pull request
Jul 16, 2025
* PHP-8.3: ext/xml: Suppress libxml deprecation for `_xmlParserCtxt.inState` (#19131)
nielsdos
added a commit
that referenced
this pull request
Jul 16, 2025
* PHP-8.4: ext/xml: Suppress libxml deprecation for `_xmlParserCtxt.inState` (#19131)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FreeBSD build fails due to the deprecation and -Werror: