PG-1658 Remove server key if it is the unused default key #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function counts the number of encryption keys in the key file associated with the given OID. Name it accordingly. Also remove comment about only user which is no longer true.
Previously this was left behind even if the default key was deleted. Check if any WAL encryption keys exist and allow removal if there are none.
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (83.61%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #484 +/- ##
=====================================================
+ Coverage 83.47% 83.61% +0.13%
=====================================================
Files 21 21
Lines 2766 2770 +4
Branches 435 436 +1
=====================================================
+ Hits 2309 2316 +7
+ Misses 371 369 -2
+ Partials 86 85 -1
🚀 New features to boost your workflow:
|
AndersAstrand
merged commit 7491b0a
into
percona:TDE_REL_17_STABLE
18 of 21 checks passed
AndersAstrand
deleted the
tde/remove-server-key-if-it-is-unused-default-principal-key
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was left behind even if the default key was deleted. Check if any WAL encryption keys exist and allow removal if there are none.
https://perconadev.atlassian.net/browse/PG-1658
We do have a bug here where we will remove the key even if it was explicitly set with
pg_tde_set_server_key(), but the same is true for the database keys, so the behavior is consistent. I will report this as a bug in jira though.