Skip to content

PG-1656 Add sample outputs for Global Principal Key Configuration commands #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 25, 2025
Merged

PG-1656 Add sample outputs for Global Principal Key Configuration commands #474

merged 10 commits into from
Jul 25, 2025

Conversation

Andriciuc
Copy link
Collaborator

No description provided.

@Andriciuc Andriciuc marked this pull request as ready for review July 18, 2025 08:43
@Andriciuc Andriciuc requested a review from nastena1606 as a code owner July 18, 2025 08:43
@Andriciuc Andriciuc requested a review from AndersAstrand July 18, 2025 08:52
@AndersAstrand
Copy link
Collaborator

Here is a list of user facing functions that return void, maybe some other places in the docs needs the same treatment as this?

 pg_tde_add_database_key_provider
 pg_tde_add_database_key_provider_file
 pg_tde_add_database_key_provider_kmip
 pg_tde_add_database_key_provider_vault_v2
 pg_tde_add_global_key_provider
 pg_tde_add_global_key_provider_file
 pg_tde_add_global_key_provider_kmip
 pg_tde_add_global_key_provider_vault_v2
 pg_tde_change_database_key_provider
 pg_tde_change_database_key_provider_file
 pg_tde_change_database_key_provider_kmip
 pg_tde_change_database_key_provider_vault_v2
 pg_tde_change_global_key_provider
 pg_tde_change_global_key_provider_file
 pg_tde_change_global_key_provider_kmip
 pg_tde_change_global_key_provider_vault_v2
 pg_tde_create_key_using_database_key_provider
 pg_tde_create_key_using_global_key_provider
 pg_tde_delete_database_key_provider
 pg_tde_delete_default_key
 pg_tde_delete_global_key_provider
 pg_tde_delete_key
 pg_tde_set_default_key_using_global_key_provider
 pg_tde_set_key_using_database_key_provider
 pg_tde_set_key_using_global_key_provider
 pg_tde_set_server_key_using_global_key_provider
 pg_tde_verify_default_key
 pg_tde_verify_key
 pg_tde_verify_server_key

@Andriciuc
Copy link
Collaborator Author

Considering the above functions, I have added a new note to the functions and multi-tenant topics, in the beginning, where they are most referenced:

!!! note
If no error is reported when running the commands below, the operation completed successfully.

@AndersAstrand
Copy link
Collaborator

Looks good.

@Andriciuc Andriciuc added the documentation Improvements or additions to documentation label Jul 22, 2025
@nastena1606 nastena1606 temporarily deployed to PG-1656-fix - INTERNAL-pg_tde docs PR #474 July 25, 2025 15:02 — with Render Destroyed
@Andriciuc Andriciuc merged commit 0ee3f3a into TDE_REL_17_STABLE Jul 25, 2025
1 check passed
@Andriciuc Andriciuc deleted the PG-1656-fix branch July 25, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersAstrand AndersAstrand AndersAstrand approved these changes

@nastena1606 nastena1606 Awaiting requested review from nastena1606 nastena1606 is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andriciuc @AndersAstrand @nastena1606