Make pg_rewind work with encrypted WAL #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (83.61%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #335 +/- ##
=====================================================
- Coverage 84.65% 83.61% -1.05%
=====================================================
Files 21 21
Lines 2588 2765 +177
Branches 401 434 +33
=====================================================
+ Hits 2191 2312 +121
- Misses 316 368 +52
- Partials 81 85 +4
🚀 New features to boost your workflow:
|
dutow
reviewed
Jul 16, 2025
There was a problem hiding this comment.
For the second commit:
These tests are a copy of upstream's pg_rewind tests with small changes
in setup_cluster to set WAL encryption on.
Can you split this commit into two, one that just copies the files, and another that contains only the required modifications?
These tests are a carbon copy of upstream's pg_rewind tests. Changes for WAL encryption will be added in the following commit. `standby_source` test is not copied as it fails because of changes needed in pg_basebackup.
Now the TDE version of pg_rewind tests runs with the WAL encryption ON
We use TLI to calculate encryption IV, therefore, data in segments has to be re-encrypted when copied to the new timeline. For PG-1412
|
@dutow I split the tests commit |
dutow
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal was to pass pg_rewind tests to find and fix WAL-related issues. Along with that, now we have pg_rewind working with encrypted WAL. There are no changes in the user interface.
This PR omits one of the pg_rewind tests. That fails due to pg_basebackup (see PG-1603).
For PG-1037, PG-1412