Skip to content

K8SPG-826 use /tmp/pmm for pmm3 env var PMM_AGENT_PATHS_TEMPDIR #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2025
Merged

K8SPG-826 use /tmp/pmm for pmm3 env var PMM_AGENT_PATHS_TEMPDIR #1225

merged 2 commits into from
Jul 16, 2025

Conversation

gkech
Copy link
Contributor

@gkech gkech commented Jul 15, 2025 •
edited
Loading

K8SPG-826 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:

The pmm-client container on PMM3 uses the /tmp directory, but on OpenShift, this directory will be overwritten by PMM3 when pods restart, leading to potential data loss or issues with metric collection.

This PR updates the configuration to use a different temporary directory for pmm-client regardless of platform, ensuring data safety across pod restarts.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@gkech gkech marked this pull request as ready for review July 15, 2025 22:31
@gkech gkech force-pushed the K8SPG-826 branch 2 times, most recently from ef02d37 to d53a0d7 Compare July 16, 2025 07:59
@gkech gkech changed the title K8SPG-826 use /tmp/pmm when openshift is enabled on pmm3 K8SPG-826 use /tmp/pmm for pmm3 env var PMM_AGENT_PATHS_TEMPDIR Jul 16, 2025
@JNKPercona
Copy link
Collaborator

Test Name Result Time
backup-enable-disable passed 00:06:33
custom-extensions passed 00:08:38
custom-tls passed 00:04:55
database-init-sql passed 00:03:20
demand-backup passed 00:23:43
finalizers passed 00:03:42
init-deploy passed 00:03:08
monitoring passed 00:07:19
monitoring-pmm3 passed 00:07:31
one-pod passed 00:05:23
operator-self-healing passed 00:07:58
pgvector-extension passed 00:02:41
pitr passed 00:11:57
scaling passed 00:04:51
scheduled-backup passed 00:24:31
self-healing passed 00:08:52
sidecars passed 00:02:21
start-from-backup passed 00:11:30
tablespaces passed 00:07:43
telemetry-transfer passed 00:03:13
upgrade-consistency passed 00:06:26
upgrade-minor passed 00:05:36
users passed 00:03:28
We run 23 out of 23 02:55:32

commit: 3e5e118
image: perconalab/percona-postgresql-operator:PR-1225-3e5e1187d

@hors hors merged commit b565ffc into main Jul 16, 2025
12 of 15 checks passed
@hors hors deleted the K8SPG-826 branch July 16, 2025 11:11
jvpasinatto pushed a commit that referenced this pull request Jul 16, 2025
@gkech @hors @jvpasinatto
K8SPG-826 use /tmp/pmm for pmm PMM_AGENT_PATHS_TEMPDIR (#1225)
49da79e 
Co-authored-by: Viacheslav Sarzhan <slava.sarzhan@percona.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hors hors hors approved these changes

@egegunes egegunes egegunes approved these changes

@nmarukovich nmarukovich nmarukovich approved these changes

@eleo007 eleo007 eleo007 approved these changes

@jvpasinatto jvpasinatto Awaiting requested review from jvpasinatto

@valmiranogueira valmiranogueira Awaiting requested review from valmiranogueira

@pooknull pooknull Awaiting requested review from pooknull pooknull is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gkech @JNKPercona @hors @egegunes @nmarukovich @eleo007