K8SPG-719 fixes on the deploy_pmm3_server for openshift #1224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkech
requested review from
jvpasinatto,
eleo007 and
valmiranogueira
as code owners
eleo007
reviewed
Jul 15, 2025
| @@ -384,24 +383,25 @@ deploy_pmm3_server() { | |||
| oc create rolebinding pmm-pg-operator-namespace-only --role percona-postgresql-operator --serviceaccount=$NAMESPACE:pmm-server -n "${NAMESPACE}" | |||
| oc patch role/percona-postgresql-operator --type json -p='[{"op":"add","path": "/rules/-","value":{"apiGroups":["security.openshift.io"],"resources":["securitycontextconstraints"],"verbs":["use"],"resourceNames":["privileged"]}}]' -n "$NAMESPACE" | |||
| fi | |||
| helm install monitoring --set imageTag=${IMAGE_PMM3_SERVER#*:} --set imageRepo=${IMAGE_PMM3_SERVER%:*} --set platform=$platform --set sa=pmm-server --set supresshttp2=false https://percona-charts.storage.googleapis.com/pmm-server-${PMM_SERVER_VERSION}.tgz -n "$NAMESPACE" | |||
| else | |||
| platform=kubernetes | |||
There was a problem hiding this comment.
Don't we remove platform for not openshift in this case?
There was a problem hiding this comment.
I think if we dont specify anything we default to k8s, e.g. in ps we don't specify it.
eleo007
reviewed
Jul 15, 2025
commit: 16d2d38 |
hors
approved these changes
Jul 16, 2025
eleo007
approved these changes
Jul 16, 2025
jvpasinatto
pushed a commit
that referenced
this pull request
Jul 16, 2025
* K8SPG-719 fixes on the deploy_pmm3_server for openshift * shfmt * remove platform specific set * move init on top of the function * add retry func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Errors observed:
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability