Skip to content

K8SPG-748 update statuses #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

K8SPG-748 update statuses #1220

wants to merge 10 commits into from
+1,229 −20

Conversation

nmarukovich
Copy link
Contributor

@nmarukovich nmarukovich commented Jul 14, 2025 •
edited
Loading

K8SPG-748 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
we need to synchronize statuses from postgres cluster to percona cluster

status:
  conditions:
    - lastTransitionTime: "2025-07-17T14:31:56Z"
      message: ""
      reason: AllConditionsAreTrue
      status: "True"
      type: ReadyForBackup
    - lastTransitionTime: "2025-07-17T14:30:01Z"
      message: pgBackRest dedicated repository host is ready
      observedGeneration: 1
      reason: RepoHostReady
      status: "True"
      type: PGBackRestRepoHostReady
    - lastTransitionTime: "2025-07-17T14:30:19Z"
      message: pgBackRest replica create repo is ready for backups
      observedGeneration: 1
      reason: StanzaCreated
      status: "True"
      type: PGBackRestReplicaRepoReady
    - lastTransitionTime: "2025-07-17T14:31:55Z"
      message: pgBackRest replica creation is now possible
      observedGeneration: 1
      reason: RepoBackupComplete
      status: "True"
      type: PGBackRestReplicaCreate
    - lastTransitionTime: "2025-07-17T14:30:03Z"
      message: Deployment has minimum availability.
      observedGeneration: 1
      reason: MinimumReplicasAvailable
      status: "True"
      type: ProxyAvailable
  host: demand-backup-pgbouncer.kuttl-test-thorough-piranha.svc
  installedCustomExtensions: []
  observedGeneration: 3
  patroniStatus:
    patroni:
      systemIdentifier: "7528058106515730508"
    patroniVersion: 4.0.5
  pgbackrest:
    manualBackup:
      finished: false
      id: demand-backup-full-azure
    repoHost:
      apiVersion: apps/v1
      kind: StatefulSet
      ready: true
    repos:
      - name: repo1
        replicaCreateBackupComplete: true
        repoOptionsHash: bd47857d6
        stanzaCreated: true
      - name: repo3
        repoOptionsHash: cf4fc86fb
        stanzaCreated: true

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

github-actions[bot]
github-actions bot reviewed Jul 17, 2025
View reviewed changes
percona/controller/pgcluster/status.go
@@ -2,7 +2,6 @@ package pgcluster

import (
"context"

"github.com/pkg/errors"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[goimports-reviser] reported by reviewdog 🐶

Suggested change
"github.com/pkg/errors"
"github.com/pkg/errors"

@nmarukovich nmarukovich marked this pull request as ready for review July 18, 2025 08:57
@JNKPercona
Copy link
Collaborator

Test Name Result Time
backup-enable-disable passed 00:07:19
custom-extensions passed 00:08:29
custom-tls passed 00:06:26
database-init-sql passed 00:03:25
demand-backup passed 00:24:20
finalizers passed 00:03:51
init-deploy passed 00:03:47
monitoring passed 00:07:20
monitoring-pmm3 passed 00:07:33
one-pod passed 00:05:47
operator-self-healing passed 00:08:14
pgvector-extension passed 00:02:44
pitr passed 00:11:22
scaling passed 00:04:54
scheduled-backup passed 00:26:45
self-healing passed 00:08:53
sidecars passed 00:03:26
start-from-backup passed 00:10:48
tablespaces passed 00:07:45
telemetry-transfer passed 00:03:28
upgrade-consistency passed 00:04:56
upgrade-minor passed 00:05:44
users passed 00:04:23
We run 23 out of 23 03:01:48

commit: 6667b96
image: perconalab/percona-postgresql-operator:PR-1220-6667b9615

gkech
gkech reviewed Jul 18, 2025
View reviewed changes
pkg/apis/pgv2.percona.com/v2/perconapgcluster_types.go
@@ -443,7 +443,11 @@ type PerconaPGClusterStatus struct {

// +optional
// +operator-sdk:csv:customresourcedefinitions:type=status
PatroniVersion string `json:"patroniVersion"`
PatroniStatus PatroniStatus `json:"patroniStatus,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this will look like this

  Patroni Status:
    Patroni:
      System Identifier:  7528392001833009250
    Patroni Version:      4.0.5

There is a lot of repetition of the reference to Patroni, making the status very verbose.

I think we should have something like that:

  Patroni:
    Status:
      System Identifier:  7528392001833009250
     Version:      4.0.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egegunes what do you think? if you ok, I will rename it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkech gkech gkech left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@jvpasinatto jvpasinatto Awaiting requested review from jvpasinatto jvpasinatto is a code owner

@eleo007 eleo007 Awaiting requested review from eleo007 eleo007 is a code owner

@valmiranogueira valmiranogueira Awaiting requested review from valmiranogueira valmiranogueira is a code owner

@hors hors Awaiting requested review from hors hors is a code owner

@egegunes egegunes Awaiting requested review from egegunes egegunes is a code owner

@pooknull pooknull Awaiting requested review from pooknull pooknull is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmarukovich @JNKPercona @gkech