Skip to content

K8SPG-718 patroni metrics to pmm #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

K8SPG-718 patroni metrics to pmm #1209

wants to merge 5 commits into from
+24 −5

Conversation

gkech
Copy link
Contributor

@gkech gkech commented Jul 4, 2025 •
edited
Loading

K8SPG-718 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
The patroni metrics were not available in PMM. Given that patroni runs in TLS mode, we need to utilize an option that was added on PMM3.3 that skips the tls verification. The auto generated certificates do not contain the localhost 127.0.0.1 in its Subject Alternative Names (SANs).

The related feature will not be available in PMM2.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:

The e2e test for pmm3 is updated to query a selected patroni metric to verify that the integration is done properly.

Also visible through the PMM dashboard:

Screenshot 2025-07-07 at 11 00 25 AM

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@gkech gkech force-pushed the K8SPG-718 branch 2 times, most recently from c811bad to da7f73c Compare July 4, 2025 11:45
@gkech gkech marked this pull request as ready for review July 7, 2025 07:50
gkech
gkech commented Jul 7, 2025
View reviewed changes
@nmarukovich
Copy link
Contributor

nmarukovich commented Jul 7, 2025 •
edited
Loading

looks good for me, waiting for cr version fix

@gkech
Copy link
Contributor Author

gkech commented Jul 8, 2025

the test failures both for e2e and unit are expected since we added this commit: 74c0851

nmarukovich
nmarukovich previously approved these changes Jul 15, 2025
View reviewed changes
pooknull
pooknull reviewed Jul 15, 2025
View reviewed changes
Copy link
Contributor

@pooknull pooknull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will approve after the unit tests are fixed.

egegunes
egegunes previously approved these changes Jul 16, 2025
View reviewed changes
@gkech gkech dismissed stale reviews from egegunes and nmarukovich via 28c2854 July 18, 2025 13:21
@JNKPercona
Copy link
Collaborator

Test Name Result Time
backup-enable-disable passed 00:08:07
custom-extensions passed 00:09:45
custom-tls passed 00:05:58
database-init-sql passed 00:03:32
demand-backup passed 00:28:50
finalizers passed 00:04:19
init-deploy passed 00:03:12
monitoring passed 00:08:11
monitoring-pmm3 failure 00:06:59
one-pod passed 00:06:00
operator-self-healing passed 00:07:51
pgvector-extension passed 00:02:44
pitr passed 00:11:54
scaling passed 00:05:09
scheduled-backup passed 00:29:25
self-healing passed 00:08:58
sidecars passed 00:02:16
start-from-backup passed 00:10:46
tablespaces passed 00:07:56
telemetry-transfer passed 00:03:25
upgrade-consistency passed 00:05:47
upgrade-minor failure 00:03:23
users passed 00:04:24
We run 23 out of 23 03:09:04

commit: 28c2854
image: perconalab/percona-postgresql-operator:PR-1209-28c2854ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvpasinatto jvpasinatto Awaiting requested review from jvpasinatto jvpasinatto is a code owner

@eleo007 eleo007 Awaiting requested review from eleo007 eleo007 is a code owner

@valmiranogueira valmiranogueira Awaiting requested review from valmiranogueira valmiranogueira is a code owner

@hors hors Awaiting requested review from hors hors is a code owner

@nmarukovich nmarukovich Awaiting requested review from nmarukovich nmarukovich is a code owner

@egegunes egegunes Awaiting requested review from egegunes egegunes is a code owner

@pooknull pooknull Awaiting requested review from pooknull pooknull is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gkech @nmarukovich @JNKPercona @egegunes @pooknull