K8SPG 798 remove watch secrets unit test #1183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
The
Watching secrets
envtest that we maintain is very flaky. When it is failing it requires someone to retrigger it until it passes.The main reason for its failing is the assertions it performs for the reconcile count. In general we don't perform similar assertions to other parts of the codebase or in other operator (maybe I'm wrong here though). Also these assertions seem redundant for the test itself. So the proposal for this PR is to remove the test completely since it is not reliable and it's basic behaviour of updating secrets not unit test worthy by itself.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability