Skip to content

K8SPG 798 remove watch secrets unit test #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 28, 2025
Merged

Conversation

gkech
Copy link
Contributor

@gkech gkech commented Jun 25, 2025

K8SPG-798 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:

The Watching secrets envtest that we maintain is very flaky. When it is failing it requires someone to retrigger it until it passes.

Screenshot 2025-06-24 at 11 24 00 AM

The main reason for its failing is the assertions it performs for the reconcile count. In general we don't perform similar assertions to other parts of the codebase or in other operator (maybe I'm wrong here though). Also these assertions seem redundant for the test itself. So the proposal for this PR is to remove the test completely since it is not reliable and it's basic behaviour of updating secrets not unit test worthy by itself.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@gkech gkech force-pushed the K8SPG-798-watch-secrets-unit-test branch 3 times, most recently from ef605da to b2939d6 Compare June 25, 2025 10:26
@gkech gkech force-pushed the K8SPG-798-watch-secrets-unit-test branch from b2939d6 to 00f6a89 Compare June 25, 2025 10:29
@gkech gkech marked this pull request as ready for review June 25, 2025 10:34
@gkech gkech changed the title K8SPG 798 watch secrets unit test K8SPG 798 remove watch secrets unit test Jun 27, 2025
@JNKPercona
Copy link
Collaborator

Test name Status
backup-enable-disable passed
custom-extensions passed
custom-tls passed
demand-backup passed
finalizers passed
init-deploy passed
monitoring passed
monitoring-pmm3 passed
one-pod passed
operator-self-healing passed
pitr passed
scaling passed
scheduled-backup passed
self-healing passed
sidecars passed
start-from-backup passed
tablespaces passed
telemetry-transfer passed
upgrade-consistency passed
upgrade-minor passed
users passed
We run 21 out of 21

commit: d312f17
image: perconalab/percona-postgresql-operator:PR-1183-d312f1718

@hors hors merged commit 3ea3892 into main Jun 28, 2025
10 of 13 checks passed
@hors hors deleted the K8SPG-798-watch-secrets-unit-test branch June 28, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants