Skip to content

K8SPG-750 fix env var ordering #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

K8SPG-750 fix env var ordering #1172

merged 1 commit into from
Jun 23, 2025

Conversation

gkech
Copy link
Contributor

@gkech gkech commented Jun 23, 2025

K8SPG-750 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
The ordering of the env vars does not allow the proper configuration of the pre run script causing the issue illustrated on below.

Screenshot 2025-06-23 at 4 01 53 PM

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Improve the logic of the prerun script building so that the fields are populated for cluster and additional params for pmm.

Screenshot 2025-06-23 at 5 28 19 PM

On the screenshot above, notice the cluster and environment labels on the timeseries.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@gkech gkech force-pushed the K8SPG-750-fix-pmm-params branch from 02563ea to 9fe428b Compare June 23, 2025 14:00
@gkech gkech marked this pull request as ready for review June 23, 2025 14:34
@JNKPercona
Copy link
Collaborator

Test name Status
backup-enable-disable passed
custom-extensions passed
custom-tls passed
demand-backup passed
finalizers passed
init-deploy passed
monitoring passed
monitoring-pmm3 passed
one-pod passed
operator-self-healing passed
pitr passed
scaling passed
scheduled-backup passed
self-healing failure
sidecars passed
start-from-backup passed
tablespaces passed
telemetry-transfer passed
upgrade-consistency passed
upgrade-minor passed
users passed
We run 21 out of 21

commit: 9fe428b
image: perconalab/percona-postgresql-operator:PR-1172-9fe428b22

@hors hors merged commit 238a5cc into main Jun 23, 2025
17 of 20 checks passed
@hors hors deleted the K8SPG-750-fix-pmm-params branch June 23, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants