K8SPG-792 Make patroni check check respect default image settings #1167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Jaruszewski <jjaruszewski@man.poznan.pl>
Kajot-dev
requested review from
hors,
egegunes,
pooknull,
nmarukovich and
gkech
as code owners
|
|
gkech
reviewed
Jun 10, 2025
| @@ -245,6 +246,12 @@ func (cr *PerconaPGCluster) Default() { | |||
| } | |||
| } | |||
|
|
|||
| func (cr *PerconaPGCluster) PostgresImage() string { | |||
There was a problem hiding this comment.
We can introduce a very basic unit test to verify in a consistent way the functionality in future iterations.
There was a problem hiding this comment.
Added unit tests for the default image behaviour
Signed-off-by: Jakub Jaruszewski <jjaruszewski@man.poznan.pl>
Signed-off-by: Jakub Jaruszewski <jjaruszewski@man.poznan.pl>
gkech
reviewed
Jun 16, 2025
Signed-off-by: Jakub Jaruszewski <jjaruszewski@man.poznan.pl>
Signed-off-by: Jakub Jaruszewski <jjaruszewski@man.poznan.pl>
gkech
approved these changes
Jun 30, 2025
egegunes
approved these changes
Jun 30, 2025
commit: ad5c5a4 |
|
@Kajot-dev thank you for your contribution. We will include this fix in PGO 2.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
See #1148
Cause:
Makes pod with patroni version check respect default image if there is any
Solution:
Wrapped around builtin PGO function from upstream. Would be a problem importing
pkg/apis/pgv2.percona.com/v2/perconapgcluster_types.gointo PGO config module due to dependency cycle.fixes: #1148
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability