[maintenance] Various maintenance stuff #652
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. gitignore coverage.lcov generated by `yarn coverage` 2. `yarn install` changes two files to executables → save it in git 3. `yarn impact`: 1. calls an old now-non-existent path 2. should better escape an argument in git command 3. should trim the current branch to avoid a newline at the end
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/peg-js/pegjs/nhirgzp4y |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type
Prerequisites
Description
yarn coverageyarn installchanges two files to executables → save it in gityarn impact:I started this commit to fix the executable flags since 4 current PRs do this same change (so it will merge without issue), and I tested
yarn impactwhich appears to have some issues.