DEPR: PeriodDtype.freq #61897
Open
DEPR: PeriodDtype.freq #61897
+56
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could do "offset" for the BaseOffset object and "unit" for the string? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Motivated by #47227.
First (and by a wide margin smallest) of several PRs to deprecate using
freqto refer to a Period's resolution. If we go down this route, the other PRs will incrementally do the same forfreqin the Period constructor, thenfreqas a Period attribute, then the same for PeriodArray/Index. We shouldn't merge this until we're agreed to do this across the board.This uses "unit" as the replacement, as that is also what we use for Timestamp/Timedelta. But while it has roughly the same semantic meaning, Period.unit does return a different type from Timestamp.unit, which might be a reason to use a third term? Also "unit" is overloaded in to_datetime/to_timedelta. So while "unit" is the best idea I've had, I'll understand if people want to bikeshed.
cc @mroeschke @jorisvandenbossche