BUG: disallow exotic np.datetime64 unit #61882
Merged
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
reviewed
Jul 17, 2025
pandas/_libs/tslibs/conversion.pyx
Outdated
| @@ -367,6 +369,13 @@ cdef _TSObject convert_to_tsobject(object ts, tzinfo tz, str unit, | |||
| if checknull_with_nat_and_na(ts): | |||
| obj.value = NPY_NAT | |||
| elif cnp.is_datetime64_object(ts): | |||
| num = (<PyDatetimeScalarObject*>obj).obmeta.num | |||
There was a problem hiding this comment.
Suggested change
| num = (<PyDatetimeScalarObject*>obj).obmeta.num | |
| num = (<PyDatetimeScalarObject*>ts).obmeta.num |
Took me embarrassingly long to spot :).
There was a problem hiding this comment.
You're embarrassed? I'm the one who screwed it up in the first place!
mroeschke
reviewed
Jul 17, 2025
pandas/_libs/tslibs/conversion.pyx
Outdated
| raise ValueError( | ||
| # GH#25611 | ||
| "np.datetime64 objects with units containing a multiplier are " | ||
| "not supported", num |
There was a problem hiding this comment.
Is the num at the end here intended?
There was a problem hiding this comment.
that was for debugging, will update
mroeschke
approved these changes
Jul 17, 2025
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This doesn't work locally for reasons described here. @seberg says it should work, so let's see if the CI can prove him right.