Skip to content

Tags: pabelanger/github3.py

Tags

temp/missing-commit-id-a27665db-107b-4281-80a6-8655bc3a97ca

Toggle temp/missing-commit-id-a27665db-107b-4281-80a6-8655bc3a97ca's commit message 
Don't expect commit_id for PullReview

In some cases, a PullReview may not have a commit_id (I am not sure why
that is). In this case, we should not always expect it to be there.

  2019-05-30 21:20:25,678 ERROR zuul.GithubEventConnector: Exception moving GitHub event:
  Traceback (most recent call last):
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/github3/models.py", line 48, in __init__
      self._update_attributes(json)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/github3/pulls.py", line 961, in _update_attributes
      self.commit_id = review["commit_id"]
  KeyError: 'commit_id'

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 484, in run
      GithubEventProcessor(self, data).run()
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 218, in run
      self._handle_event()
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 265, in _handle_event
      refresh=True)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 903, in _getChange
      self._updateChange(change)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 1008, in _updateChange
      change.number)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 1246, in getPullReviews
      revs = [review.as_dict() for review in pr_obj.reviews()]
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 1246, in <listcomp>
      revs = [review.as_dict() for review in pr_obj.reviews()]
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/github3/structs.py", line 122, in __iter__
      yield cls(i)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/github3/models.py", line 50, in __init__
      raise exceptions.IncompleteResponse(json, kerr)
  github3.exceptions.IncompleteResponse: None The library was expecting more data in the response (KeyError('commit_id',)). Either GitHub modified it's response body, or your token is not prop
  erly scoped to retrieve this information.

  https://api.github.com/repos/ansible/ansible/pulls/45469/reviews

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

temp/missing-commit-id-0bbde0ee-96cb-4388-b45f-3c5cb0968872

Toggle temp/missing-commit-id-0bbde0ee-96cb-4388-b45f-3c5cb0968872's commit message 
Don't expect commit_id for PullReview

In some cases, a PullReview may not have a commit_id (I am not sure why
that is). In this case, we should not always expect it to be there.

  2019-05-30 21:20:25,678 ERROR zuul.GithubEventConnector: Exception moving GitHub event:
  Traceback (most recent call last):
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/github3/models.py", line 48, in __init__
      self._update_attributes(json)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/github3/pulls.py", line 961, in _update_attributes
      self.commit_id = review["commit_id"]
  KeyError: 'commit_id'

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 484, in run
      GithubEventProcessor(self, data).run()
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 218, in run
      self._handle_event()
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 265, in _handle_event
      refresh=True)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 903, in _getChange
      self._updateChange(change)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 1008, in _updateChange
      change.number)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 1246, in getPullReviews
      revs = [review.as_dict() for review in pr_obj.reviews()]
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 1246, in <listcomp>
      revs = [review.as_dict() for review in pr_obj.reviews()]
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/github3/structs.py", line 122, in __iter__
      yield cls(i)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/github3/models.py", line 50, in __init__
      raise exceptions.IncompleteResponse(json, kerr)
  github3.exceptions.IncompleteResponse: None The library was expecting more data in the response (KeyError('commit_id',)). Either GitHub modified it's response body, or your token is not prop
  erly scoped to retrieve this information.

  https://api.github.com/repos/ansible/ansible/pulls/45469/reviews

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

temp/missing-commit-id-8ed41e71-f55b-45c6-91b7-7add109875c0

Toggle temp/missing-commit-id-8ed41e71-f55b-45c6-91b7-7add109875c0's commit message 
Don't expect commit_id for PullReview

In some cases, a PullReview may not have a commit_id (I am not sure why
that is). In this case, we should not always expect it to be there.

  2019-05-30 21:20:25,678 ERROR zuul.GithubEventConnector: Exception moving GitHub event:
  Traceback (most recent call last):
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/github3/models.py", line 48, in __init__
      self._update_attributes(json)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/github3/pulls.py", line 961, in _update_attributes
      self.commit_id = review["commit_id"]
  KeyError: 'commit_id'

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 484, in run
      GithubEventProcessor(self, data).run()
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 218, in run
      self._handle_event()
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 265, in _handle_event
      refresh=True)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 903, in _getChange
      self._updateChange(change)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 1008, in _updateChange
      change.number)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 1246, in getPullReviews
      revs = [review.as_dict() for review in pr_obj.reviews()]
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/zuul/driver/github/githubconnection.py", line 1246, in <listcomp>
      revs = [review.as_dict() for review in pr_obj.reviews()]
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/github3/structs.py", line 122, in __iter__
      yield cls(i)
    File "/opt/venv/zuul-3.8.1/lib/python3.6/site-packages/github3/models.py", line 50, in __init__
      raise exceptions.IncompleteResponse(json, kerr)
  github3.exceptions.IncompleteResponse: None The library was expecting more data in the response (KeyError('commit_id',)). Either GitHub modified it's response body, or your token is not prop
  erly scoped to retrieve this information.

  https://api.github.com/repos/ansible/ansible/pulls/45469/reviews

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

1.3.0

Toggle 1.3.0's commit message

Verified

This tag was signed with the committer’s verified signature.
sigmavirus24 Ian Stapleton Cordasco
GPG key ID: C9D7A2604B4FCB2A
Verified
Learn about vigilant mode 
Release v1.3.0

1.2.0

Toggle 1.2.0's commit message

Verified

This tag was signed with the committer’s verified signature.
sigmavirus24 Ian Stapleton Cordasco
GPG key ID: C9D7A2604B4FCB2A
Verified
Learn about vigilant mode 
Release v1.2.0

1.1.0

Toggle 1.1.0's commit message

Verified

This tag was signed with the committer’s verified signature.
sigmavirus24 Ian Stapleton Cordasco
GPG key ID: C9D7A2604B4FCB2A
Verified
Learn about vigilant mode 
Release v1.1.0

1.0.2

Toggle 1.0.2's commit message

Verified

This tag was signed with the committer’s verified signature. The key has expired.
omgjlk Jesse Keating
GPG key ID: E8F6F749F8F4B427
Expired
Verified
Learn about vigilant mode 
Release v1.0.2

1.0.1

Toggle 1.0.1's commit message

Verified

This tag was signed with the committer’s verified signature.
sigmavirus24 Ian Stapleton Cordasco
GPG key ID: C9D7A2604B4FCB2A
Verified
Learn about vigilant mode 
Release v1.0.1

1.0.0

Toggle 1.0.0's commit message

Verified

This tag was signed with the committer’s verified signature.
sigmavirus24 Ian Stapleton Cordasco
GPG key ID: C9D7A2604B4FCB2A
Verified
Learn about vigilant mode 
Release v1.0.0

0.9.6

Toggle 0.9.6's commit message

Verified

This tag was signed with the committer’s verified signature.
sigmavirus24 Ian Stapleton Cordasco
GPG key ID: 656D3395E4A9791A
Verified
Learn about vigilant mode 
Release v0.9.6