Realtime: only cancel response if necessary #1243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2025
rm-openai
added a commit
that referenced
this pull request
Jul 25, 2025
|
Please check Python 3.9 compatibility |
seratch
approved these changes
Jul 29, 2025
| @@ -483,6 +491,9 @@ async def _handle_ws_event(self, event: dict[str, Any]): | |||
| await self._emit_event(RealtimeModelTurnEndedEvent()) | |||
| elif parsed.type == "session.created": | |||
| await self._send_tracing_config(self._tracing_config) | |||
| self._update_created_session(parsed.session) # type: ignore | |||
There was a problem hiding this comment.
I looked into the ways to make the type compatible here, but found it's way more complicated than I expect and dealing with it does not bring any benefits to the code... 😅 So, having ignore comments for these is okay for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need not cancel a response if the server will cancel it.