frontend: Fix misaligned progress percentage in Remux dialog #12378 #12402
+31
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct#12378 Updated the Remux dialog UI to correctly align the percentage text label to the right of the progress bar, without overlaying it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Remux progress bar using the default progress text of QProgressBar, which was not aligned properly, and would be overlaid on the progress bar itself. I changed it to be a QLabel that is aligned properly to the right of the progress bar, in its same horizontal row.
Motivation and Context
Fixes #12378
This is a fix for the open issue #12378
The progress percentage looked like this before the change, and the number was not visible properly
How Has This Been Tested?
I tested this manually by building after the changes and tested remuxing multiple files. The output and UI changes were obtained as in the screenshots provided.
I tested on Windows 11 10.0.26100 using the windows-x64 RelWithDebInfo build configuration
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: