Skip to content

frontend: Cleanup Qt GuiPrivate linkage #12328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented Jul 1, 2025

Description

Closes #12321

With Qt 6.9.0 and later, we no longer need to link with Qt::GuiPrivate.
There was also some unneeded linkage.

Motivation and Context

As documented in #12321, 6.10 change some behaviors around private targets. Avoiding linking as of 6.9.0 is the cleanest path.

How Has This Been Tested?

CI on my fork is green.

Types of changes

  • Preemptive Bug fix (non-breaking change which fixes an issue)
  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 mentioned this pull request Jul 1, 2025
6 tasks
@tytan652 tytan652 added Linux Affects Linux Other OS (*nix) Other Unix-like systems that are not officially supported (e.g. OpenBSD) Bug Fix Non-breaking change which fixes an issue Code Cleanup Non-breaking change which makes code smaller or more readable labels Jul 1, 2025
@tytan652 tytan652 force-pushed the no-qt-gui-private branch from 786b05c to 98ba790 Compare July 2, 2025 11:18
Remove unneeded linkages and guard needed ones for Qt versions earlier
than 6.9.0.
@tytan652 tytan652 force-pushed the no-qt-gui-private branch from 98ba790 to 26dfacb Compare July 2, 2025 11:19
@Chiitoo
Copy link
Contributor

Chiitoo commented Jul 2, 2025

Looks good here now as well.

Thank you!

@Conan-Kudo
Copy link
Contributor

LGTM as well. Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Code Cleanup Non-breaking change which makes code smaller or more readable Linux Affects Linux Other OS (*nix) Other Unix-like systems that are not officially supported (e.g. OpenBSD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants