Skip to content

Be explicit about the use of the Preview channel #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

russokj
Copy link
Contributor

@russokj russokj commented Jul 16, 2025

We implicitly imply that the preview channel should not be used for production environments but listing the environments it SHOULD be used for.

Proposed changes

This change makes the exclusion from production explicit.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

We implicitly imply that the preview channel should not be used for production environments but listing the environments it SHOULD be used for.  This change makes it explicit.
@russokj russokj requested a review from a team as a code owner July 16, 2025 18:46
Copy link

github-actions bot commented Jul 16, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginxaas NGINX as a Service for Azure labels Jul 16, 2025
@russokj russokj requested review from travisamartin and amudukutore and removed request for travisamartin July 16, 2025 18:47
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/830/

@russokj
Copy link
Contributor Author

russokj commented Jul 16, 2025

I have hereby read the F5 CLA and agree to its terms

@JTorreG JTorreG merged commit 55305f4 into main Jul 17, 2025
8 checks passed
@JTorreG JTorreG deleted the russokj-preview-channel-update branch July 17, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginxaas NGINX as a Service for Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants