PINO Reweighing Schemes #618
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhpitt
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
This looks good to me. Thanks @vduruiss ! In future it would be good to come up with a clever way of integrating this with the Trainer, perhaps looping this into our functional trainer plans. But as-is I think this code will be helpful to others hoping to use PINO reweighting schemes.
config/wandb.py
Outdated
| entity: Optional[str] = None | ||
| project: Optional[str] = None | ||
| project: Optional[str] = "Burgers-Pino" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding SoftAdapt / Relobralo and a PINO example
This is a simplified version of PR611 where the schemes are used without the main Trainer.
I will come back to building the PINOTrainer later on based on @dhpitt's good suggestions, once we also have sampling/resampling strategies ready.
I addressed some of the other comments made in PR611 regarding docstrings.