Corrected spelling and grammar in FNO theory guide + fix FNO type hint and typo #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 87a0f97.
Corrected spelling and grammatical errors and improved phrasing in the FNO theory guide documentation. These changes improve readability without altering technical content.
- Corrected n_modes type hint to Tuple[int, ...]
- Replaced dict() with {} and used None as default to avoid shared mutable defaults
- Fixed typo: "liting" -> "lifting"
- Used Pythonic is for None checks
- Removed extra whitespace for consistency
|
I just committed a few other useful minor changes:
This cleans up the code. |
JeanKossaifi
reviewed
Jul 2, 2025
There was a problem hiding this comment.
This looks good, thank you @piano-miles! I just have a question about one of the types.
piano-miles
changed the title
piano-miles
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected spelling and grammar and improved phrasing in the FNO theory guide documentation. These changes improve readability without altering technical content.