Skip to content

transfer Learn PR 2473 #20600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

transfer Learn PR 2473 #20600

merged 1 commit into from
Jul 1, 2025

Conversation

Ancairon
Copy link
Member

Summary

Yesterday a PR was made in Learn, but for years now we don't do learn edits like that. It used Claude also, so it hallucinated a bit and did other edits that we already cover by scripts.

I transferred the files, only fixing breaking changes on them.

I did not review anything content-wise, I leave that to @netdata/product and @kanelatechnical. The changes are massive and nuke a lot of recent edits, so I am not the one to decide what happens here.

If this is merged I have to then make the map edits, for the changes to have effect on Learn, so I will keep an eye on this.

(From my POV I don't like how we use ML and AI as different terms, one is the scholar term and the other is the flashy term. They are the same and it looks weird using both. One or the other is where it's at)

Initial preview on original PR worked, so I am not deploying to test it. Will re-iterate with fixes if something does not work after merge.

@Ancairon Ancairon requested a review from a team June 30, 2025 09:14
@ktsaou
Copy link
Member

ktsaou commented Jun 30, 2025

@Ancairon please write in /CLAUDE.md the rules you want for PRs in learn, so that Claude Code can follow them. Just describe what you did and how things should be done.

@Ancairon
Copy link
Member Author

I can do that, but the PR should not happen on Learn anyways. It should happen here. The rules for here is use absolute paths from root for links, like ](/docs/a/b.md. To link between files.

There is no docs editing happening on the Learn repo.

@ktsaou ktsaou merged commit 1df7ff6 into netdata:master Jul 1, 2025
107 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants