improvement(go.d): add bearer_token_file to request cfg #20476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
The PR adds support for a bearer_token_file configuration option across multiple collectors’ test fixtures and improves HTTP request error handling in ClickHouse collectors.
- Introduces
bearer_token_filein YAML/JSON test configs for CockroachDB, ClickHouse, Ceph, Cassandra, Bind, Apache, and ActiveMQ. - Changes ClickHouse collector methods to handle errors from
web.NewHTTPRequestand properly propagate errors fromc.doHTTP.
Reviewed Changes
Copilot reviewed 128 out of 128 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/go/plugin/go.d/collector/*/testdata/config.yaml/.json | Added bearer_token_file entry to each collector’s config tests. |
| src/go/plugin/go.d/collector/clickhouse/collect_system_*.go | Updated web.NewHTTPRequest calls to check and return errors. |
Comments suppressed due to low confidence (1)
src/go/plugin/go.d/collector/cockroachdb/testdata/config.yaml:11
- There are no tests verifying that
bearer_token_fileis read and applied to outgoing requests. Consider adding unit tests in theweb.NewHTTPRequestsuite to confirm the file is loaded and theAuthorizationheader is correctly set.
bearer_token_file: "ok"
Ancairon
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
And read it during request creation.
Test Plan
Additional Information
For users: How does this change affect me?