Skip to content

Rename nd-mcp on windows #20404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

Conversation

stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented Jun 3, 2025

Summary
  • Rename nd-mcp to nd-mcp.exe on windows

@github-actions github-actions bot added the area/build Build system (autotools and cmake). label Jun 3, 2025
@stelfrag stelfrag marked this pull request as ready for review June 3, 2025 18:14
@stelfrag stelfrag requested review from vkalintiris and a team as code owners June 3, 2025 18:14
@stelfrag stelfrag requested review from thiagoftsm and removed request for vkalintiris June 3, 2025 20:08
@stelfrag stelfrag enabled auto-merge (squash) June 3, 2025 20:08
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binary was named properly on Linux and on Windows 11 with this PR. LGTM!

@stelfrag stelfrag merged commit 9a83540 into netdata:master Jun 4, 2025
107 checks passed
@stelfrag stelfrag deleted the adjust-windows-nd-mcp branch June 4, 2025 05:31
mario-campos pushed a commit to mario-campos/netdata that referenced this pull request Jun 5, 2025
Create nd-mcp.exe on windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build system (autotools and cmake).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants