feat(go.d): allow to debug a specific job #20394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
There was a problem hiding this comment.
Pull Request Overview
This PR enables debugging of a specific job in the go.d plugin by introducing a new "job" flag and propagating it through the CLI, agent, and Manager.
- Added a new CLI flag for job selection
- Propagated the job option through the agent configuration and into the Manager
- Applied filtering on configuration groups to run only the specified job(s)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/go/plugin/go.d/cli/cli.go | Added new CLI flag "job" for specifying a job |
| src/go/plugin/go.d/agent/jobmgr/manager.go | Introduced RunJob field and filtered configs based on job selection |
| src/go/plugin/go.d/agent/agent.go | Propagated RunJob through agent configuration |
| src/go/cmd/godplugin/main.go | Mapped the new job flag from CLI options |
stelfrag
approved these changes
Jun 2, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Jun 4, 2025
(cherry picked from commit 1578ef7)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Jun 5, 2025
(cherry picked from commit 1578ef7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related topic on Discord.
Test Plan
Additional Information
For users: How does this change affect me?