Improve datafile rotation and indexing #20354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not schedule a db rotate command if quota is ok
Log a warning if journalfile cannot be unmapped
Indicate if rotation is due to disk quota or time retention Reduce number of opcodes
Report full name of the journal file to be indexed Improve disk space reclaim log with human-readable format
Additional use of UNLINK_FILE macro Update logging to include journal file paths
thiagoftsm
approved these changes
May 29, 2025
stelfrag
added a commit
to stelfrag/netdata
that referenced
this pull request
Jun 3, 2025
* Check tier quota after indexing each file Do not schedule a db rotate command if quota is ok * Cleanup journalfile deletion code Log a warning if journalfile cannot be unmapped * Schedule database rotation / journal indexing in callbacks Indicate if rotation is due to disk quota or time retention Reduce number of opcodes * Change log level for journal indexing messages from DEBUG to INFO * Report acquired file for deletion * Allow indexing during rotation * Allow rotation during indexing * Allow the indexing to run at least once * Fix compilation warning Report full name of the journal file to be indexed Improve disk space reclaim log with human-readable format * Adjust formatting for file logging Additional use of UNLINK_FILE macro Update logging to include journal file paths * More formatting adjustments for file logging (cherry picked from commit 4812fe1)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Jun 5, 2025
* Check tier quota after indexing each file Do not schedule a db rotate command if quota is ok * Cleanup journalfile deletion code Log a warning if journalfile cannot be unmapped * Schedule database rotation / journal indexing in callbacks Indicate if rotation is due to disk quota or time retention Reduce number of opcodes * Change log level for journal indexing messages from DEBUG to INFO * Report acquired file for deletion * Allow indexing during rotation * Allow rotation during indexing * Allow the indexing to run at least once * Fix compilation warning Report full name of the journal file to be indexed Improve disk space reclaim log with human-readable format * Adjust formatting for file logging Additional use of UNLINK_FILE macro Update logging to include journal file paths * More formatting adjustments for file logging (cherry picked from commit 4812fe1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary