Improve MSSQL (Part III) #20230
Merged
Improve MSSQL (Part III) #20230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
thiagoftsm
force-pushed
the
split_collection
branch
3 times, most recently
from
ef28a32 to
b27b4b7
Compare
thiagoftsm
force-pushed
the
split_collection
branch
from
b27b4b7 to
0704282
Compare
What charts? |
I observed these issues with the MSSQL metrics, because the system had to query data before plotting. In this PR, I'm separating data collection from plotting, which prevents this issue from recurring on my host. I haven't observed this behavior in our VMs. |
stelfrag
approved these changes
May 13, 2025
What does that mean? |
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
May 21, 2025
(cherry picked from commit a78abaa)
Merged
Ferroin
pushed a commit
that referenced
this pull request
May 22, 2025
(cherry picked from commit a78abaa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running on busy servers, or computer with slow memory, it was observed gaps on charts. To address this issue, we are isolating the queries in a thread.
This PR also fixes a small issue when running on SQL Express. Previously, if a variable was not initialized, strange values could appear.
Update metdata.
This PR also does small cleanup and renames to keep a pattern.
Test Plan
Additional Information
This PR was tested with SQL Server 2022 and SQL Server Express 2019.
For users: How does this change affect me?