Improve ACLK sync shutdown process #19966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait at most 5 seconds for queries to timeout before force stopping the ACLK sync thread
thiagoftsm
approved these changes
Mar 26, 2025
stelfrag
added a commit
to stelfrag/netdata
that referenced
this pull request
Mar 31, 2025
* Refactor ACLK sync shutdown process * Mark all pending queries as cancelled Wait at most 5 seconds for queries to timeout before force stopping the ACLK sync thread * Refactor logging in ACLK synchronization process * Improve logging message for ACLK request snapshot creation (cherry picked from commit ca6e7cd)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Apr 2, 2025
* Refactor ACLK sync shutdown process * Mark all pending queries as cancelled Wait at most 5 seconds for queries to timeout before force stopping the ACLK sync thread * Refactor logging in ACLK synchronization process * Improve logging message for ACLK request snapshot creation (cherry picked from commit ca6e7cd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The ACLK synchronization thread will now accept a shutdown opcode instead of monitoring if the ACLK service should be running.