Fast restart on busy parents #19964
Merged
Fast restart on busy parents #19964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsaou
requested review from
vkalintiris,
a team,
Ferroin and
thiagoftsm
as code owners
github-actions
bot
added
area/packaging
github-actions
bot
added
area/database
and removed
area/packaging
vkalintiris
previously requested changes
Mar 26, 2025
@ktsaou we are at >= 1.5K LOC already. It's better to work on the rest of the items in another PR. |
Ferroin
reviewed
Mar 26, 2025
There was a problem hiding this comment.
@ktsaou we are at >= 1.5K LOC already. It's better to work on the rest of the items in another PR.
I also strongly second this point. We need to be better about not making huge PRs. They’re problematic to deal with when they cause a major issue, and they’re impossible to sanely backport for patch releases.
vkalintiris
reviewed
Mar 26, 2025
Imported version is LMDB_0.9.31. We only rely on 4 files. However, considering that project is very small and everything's in a single directory, I opted for simply copying everything.
Remove save to file and watcher Remove files / rename mrg-dump-load to mrg-load.c Update CMakeLists.txt
stelfrag
previously approved these changes
Mar 28, 2025
stelfrag
approved these changes
Mar 28, 2025
stelfrag
added a commit
to stelfrag/netdata
that referenced
this pull request
Mar 31, 2025
Prepopulate UUIDs to MRG to improve startup times. - [x] Pre-populate UUIDs to MRG on start (from SQLite) - [x] Cleanup obsolete UUIDs from MRG once finished This improves startup times by 3x to 5x. --------- Co-authored-by: vkalintiris <vasilis@netdata.cloud> Co-authored-by: Stelios Fragkakis <52996999+stelfrag@users.noreply.github.com> (cherry picked from commit 3d0c2b9)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Apr 2, 2025
Prepopulate UUIDs to MRG to improve startup times. - [x] Pre-populate UUIDs to MRG on start (from SQLite) - [x] Cleanup obsolete UUIDs from MRG once finished This improves startup times by 3x to 5x. --------- Co-authored-by: vkalintiris <vasilis@netdata.cloud> Co-authored-by: Stelios Fragkakis <52996999+stelfrag@users.noreply.github.com> (cherry picked from commit 3d0c2b9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepopulate UUIDs to MRG to improve startup times.
This improves startup times by 3x to 5x.