Skip to content

status file v21 #19928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 21, 2025
Merged

status file v21 #19928

merged 12 commits into from
Mar 21, 2025

Conversation

ktsaou
Copy link
Member

@ktsaou ktsaou commented Mar 21, 2025

  • do not report CI jobs
  • increase version to 21
  • make sure the machine guid filename is allocated before accessed

vkalintiris
vkalintiris previously approved these changes Mar 21, 2025
Copy link
Contributor

@vkalintiris vkalintiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure the machine guid filename is allocated before accessed

This is the important bit. I'm approving this but I think it would be better for the time being to just initialize the machine guid filename (and let the rest of the code as it is).

@ktsaou
Copy link
Member Author

ktsaou commented Mar 21, 2025

The problem is what we should do if the machine guid file cannot be initialized...

@ktsaou
Copy link
Member Author

ktsaou commented Mar 21, 2025

I will make some changes to work around this.

@ktsaou ktsaou requested review from a team and Ferroin as code owners March 21, 2025 13:02
@github-actions github-actions bot added area/database area/claim area/build Build system (autotools and cmake). labels Mar 21, 2025
ilyam8
ilyam8 previously approved these changes Mar 21, 2025
@ktsaou ktsaou merged commit 7439280 into netdata:master Mar 21, 2025
77 of 88 checks passed
stelfrag pushed a commit to stelfrag/netdata that referenced this pull request Mar 24, 2025
* do not report CI jobs

* make version 21

* make sure the machine guid filename is available on start

* fix crash

* remove machine guid maintenance from registry and make sure it never fails

* cleanup

* polishing and cleanup

* fix portability of struct stat timestamps

* increase stack traces provider buffer

(cherry picked from commit 7439280)
@stelfrag stelfrag mentioned this pull request Mar 24, 2025
Ferroin pushed a commit that referenced this pull request Mar 24, 2025
* do not report CI jobs

* make version 21

* make sure the machine guid filename is available on start

* fix crash

* remove machine guid maintenance from registry and make sure it never fails

* cleanup

* polishing and cleanup

* fix portability of struct stat timestamps

* increase stack traces provider buffer

(cherry picked from commit 7439280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants