-
Notifications
You must be signed in to change notification settings - Fork 6.1k
status file v21 #19928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status file v21 #19928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure the machine guid filename is allocated before accessed
This is the important bit. I'm approving this but I think it would be better for the time being to just initialize the machine guid filename (and let the rest of the code as it is).
The problem is what we should do if the machine guid file cannot be initialized... |
I will make some changes to work around this. |
* do not report CI jobs * make version 21 * make sure the machine guid filename is available on start * fix crash * remove machine guid maintenance from registry and make sure it never fails * cleanup * polishing and cleanup * fix portability of struct stat timestamps * increase stack traces provider buffer (cherry picked from commit 7439280)
* do not report CI jobs * make version 21 * make sure the machine guid filename is available on start * fix crash * remove machine guid maintenance from registry and make sure it never fails * cleanup * polishing and cleanup * fix portability of struct stat timestamps * increase stack traces provider buffer (cherry picked from commit 7439280)
Uh oh!
There was an error while loading. Please reload this page.