Skip to content

Store alert config asynchronously #19885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

stelfrag
Copy link
Collaborator

Summary
  • When saving alert configurations in the database, enqueue the statement in the metadata thread for processing.
    • The metadata thread will handle statement cleanup.

@stelfrag stelfrag force-pushed the store_alert_hash_async branch from 57d8b2b to 53136b3 Compare March 19, 2025 14:38
@stelfrag stelfrag marked this pull request as ready for review March 19, 2025 14:44
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is working as expected. I did not observe any SQL error running it. LGTM!

@stelfrag stelfrag merged commit 70f4422 into netdata:master Mar 20, 2025
103 checks passed
@stelfrag stelfrag deleted the store_alert_hash_async branch March 20, 2025 07:21
stelfrag added a commit to stelfrag/netdata that referenced this pull request Mar 31, 2025
Add support for running prepared SQL statements that store data, in the metadata thread

(cherry picked from commit 70f4422)
@stelfrag stelfrag mentioned this pull request Mar 31, 2025
Ferroin pushed a commit that referenced this pull request Apr 2, 2025
Add support for running prepared SQL statements that store data, in the metadata thread

(cherry picked from commit 70f4422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants